fix: pass excludeTurns to the file-change report fork - #473
Open
kevingosse wants to merge 1 commit into
Open
Conversation
Codex 0.152.0 defaults durable threads to paginated history. The app-server rejects an ephemeral fork of a paginated thread unless the fork sets excludeTurns: true. The file-change report fork did not set it, so every report failed with providerError and AIR showed no changed-files card. The report never reads the forked turns, so the flag is safe.
kevingosse
requested review from
Ololoshechkin
and
a lite review from Copilot
September 4, 2026 14:10
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped, matches the documented threadFork parameter contract, and is covered by an updated test assertion.
Pull request overview
Adjusts the file-change report flow in the ACP server to remain compatible with Codex 0.152.0’s paginated durable-thread behavior by ensuring ephemeral forks do not attempt full turn hydration.
Changes:
- Pass
excludeTurns: truewhen forking the audit/report thread used byrunAgentFileChangeReport. - Update the corresponding unit test to assert the new fork parameter.
File summaries
| File | Description |
|---|---|
src/CodexAcpClient.ts |
Adds excludeTurns: true to the file-change report threadFork call to prevent paginated-thread fork rejection. |
src/__tests__/CodexACPAgent/agent-file-change-report.test.ts |
Updates the fork expectation to include excludeTurns: true. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex 0.152.0 defaults durable threads to paginated history. The app-server rejects an ephemeral fork of a paginated thread unless the fork sets excludeTurns: true. The file-change report fork did not set it, so every report failed with providerError. The report never reads the forked turns, so the flag is safe.