feat(harness): allow disabling general-purpose subagent - #2354
Open
logicwu0 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
oss-maintainer
approved these changes
Jul 28, 2026
oss-maintainer
left a comment
oss-maintainer
left a comment
There was a problem hiding this comment.
Review: PR #2354 — feat(harness): allow disabling general-purpose subagent
Verdict: Approved ✅
Adds a disableGeneralPurposeSubagent() builder method that allows users to opt out of the built-in general-purpose subagent while keeping declared and custom subagents available.
Changes:
- New boolean flag
disableGeneralPurposeSubagentin the Builder - Conditional registration in
buildSubagentEntries()andbuildStaticSubagentEntries()— the general-purpose entry is skipped when the flag is set - Test coverage verifies the flag works correctly
Useful for users who want to restrict subagent capabilities to only explicitly declared ones, reducing the attack surface and resource usage.
All CI checks pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
HarnessAgent always registers the built-in
general-purposesubagent when subagent support is enabled. This can interfere with explicitly declared subagents by allowing the built-in agent to handle tasks intended for them.This change adds
disableGeneralPurposeSubagent()to disable only the built-in entry while keeping programmatic, workspace-defined, and custom subagents available. Both static and dynamic subagent registration paths honor the new option.Fixes #2340
Checklist
mvn spotless:apply