Repository navigation
fix: quota denial message no longer tells the agent to retry - #144
Merged
Merged
Conversation
vvillait88
added a commit
that referenced
this pull request
Oct 4, 2026
## Summary Releases 3.0.1, carrying everything merged since 3.0.0: - the quota denial message no longer tells an agent to retry; both quota deny sites in `core.ts` now say verification is unavailable for this merchant and that retrying will not help (#144) - A2A signing and transport docs and supported versions corrected (#143) - README: the UCP example imports the payment-handler builders it uses (#145), and UCP profile `keys[]` is informational (#142) Also in this PR: `@agent-score/sdk` floor raised to 2.8.1, released today. Worked with: Varun. Out of scope: nothing else is pending on main. ## Type of change - [x] Bug fix (no breaking change) - [ ] New feature (no breaking change) - [ ] Breaking change (existing callers must update) - [ ] Docs, tests, or internal maintenance only ## Public API none. The denial reason code and response shape are unchanged; only the message text differs. ## Test plan `bun run lint`, `typecheck`, `test` (1849 passed, 4 skipped) and `build` pass locally on this branch. ## Checklist - [x] Tests cover the new behavior, and the suite passes locally - [x] Lint, format, and type checks pass - [x] Docs and README examples updated if the public surface changed - [x] No secrets, credentials, or personal data in the diff or the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
/v1/assessreturns 429quota_exceededandfailOpen/fail_openis off, the gate denies withapi_errorand the quota-specificcontact_merchantinstructions ("Do not retry: the same 503 will be returned until the merchant resolves the issue"). The reason carried no message, so the body fell back to theapi_errordefault, "AgentScore is unreachable. This is transient: retry in a few seconds." An agent reading both got two opposite instructions in one response.The quota denial now carries its own message,
QUOTA_EXCEEDED_MESSAGE: "AgentScore identity verification is unavailable for this merchant. Retrying will not help." Every place that builds the quota denial sets it (the typed and the untyped 429 paths). Found in a docs audit while checking the errors reference against the SDK's emitted bodies.Type of change
Public API
Adds the exported constant
QUOTA_EXCEEDED_MESSAGEbesideQUOTA_EXCEEDED_INSTRUCTIONS. The 503 body'serror.messageon the quota path changes text; its shape and status do not. No release is cut for this alone; the next release carries it.Test plan
The quota tests now assert the message. Positive control: with the message removed from the deny sites, those tests fail; restored, they pass. Full lint, type check and test suite pass locally.
Checklist