[PR #13295/29303217 backport][3.14] Fix documented default for StreamReader.read_nowait - #13529
Conversation
(cherry picked from commit 2930321)
Confidence Score: 5/5The documentation-only PR appears safe to merge. The updated signature matches the existing Reviews (1): Last reviewed commit: "Fix documented default for StreamReader...." | Re-trigger Greptile |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.14 #13529 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 160 160
Lines 51080 51080
Branches 2761 2761
=======================================
Hits 49152 49152
Misses 1751 1751
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Merging this PR will not alter performance
Comparing Footnotes
|
This is a backport of PR #13295 as merged into master (2930321).
What do these changes do?
Correct the documented signature of
StreamReader.read_nowaitindocs/streams.rst.The reference documented it as
read_nowait(n=None), but the real signature inaiohttp/streams.pyisdef read_nowait(self, n: int = -1). The code even carries a comment recording the change:The documentation was never updated to follow. Notably the
:param int n:description directly below the signature is already correct — it says "-1for the whole internal buffer" — so the signature line was the only stale part, and it contradicted the prose sitting three lines under it.One line changed. Documentation only, no code changes.
Are there changes in behavior for the user?
No. Nothing in the library changes. The reference now shows the default the method actually has, and no longer contradicts its own parameter description.
Is it a substantial burden for the maintainers to support this?
No. One-line documentation correction with no ongoing maintenance cost.
Related issue number
None — found while comparing documented parameter defaults against the real signatures.
Checklist
CONTRIBUTORS.txtCHANGES/folderDrafted with Claude Opus 5; reviewed by @LALITH0110.