feat: add CompositionClient to cli and bump SDK to v4.38.0#215
Open
ben-kalmus wants to merge 1 commit intoalgolia:mainfrom
Open
feat: add CompositionClient to cli and bump SDK to v4.38.0#215ben-kalmus wants to merge 1 commit intoalgolia:mainfrom
ben-kalmus wants to merge 1 commit intoalgolia:mainfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 134 |
| Duplication | 151 |
TIP This summary will be updated as you push new changes.
5e25461 to
9c9f982
Compare
9c9f982 to
34d611e
Compare
34d611e to
44670b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new compositions command group to the Algolia CLI covering the full management lifecycle for Algolia Compositions (https://www.algolia.com/doc/rest-api/composition/).
This also bumps the Algolia Go SDK from v4.35.0 to v4.38.0 to pick up the composition package.
Commands added
Composition management:
Composition rule management:
Design notes
indicescommand group.Changes
go.mod / go.sum: Bump algoliasearch-client-go/v4 to v4.38.0pkg/cmdutil/factory.go: Add CompositionClient fieldpkg/cmd/factory/default.go: Implement compositionClient() factory functionpkg/cmd/root/root.go: Register NewCompositionsCmdpkg/cmd/compositions/: New command groupTests
Each command has a unit test file covering:
End to end test script:
e2e/testscripts/compositions/compositions.txtar