Skip to content

AmcRedfishDiagPlugin - #287

Merged
alexandraBara merged 4 commits into
developmentfrom
alex_proxy
Sep 29, 2026
Merged

alexandraBara merged 4 commits into
developmentfrom
alex_proxy

Conversation

@alexandraBara

Copy link
Copy Markdown
Collaborator

Summary

-AmcRedfishDiagPlugin collects AMC Redfish diagnostic archives by SSH’ing to the BMC and curling the AMC Redfish service
-It discovers a LogService that advertises CollectDiagnosticData, posts the job, polls the task, and downloads the attachment.
-Collects OEM AllLogs tar + Managers dump

Test plan

  • pytest test/unit
  • pytest test/functional (if applicable)
  • pre-commit run --all-files

Checklist

  • Added/updated tests (or explained why not)
  • Updated docs/README if behavior changed
  • No secrets or credentials committed

Sample connection_config.json:

{
  "RedfishSshProxyConnectionManager": {
    "host": "192.168.31.1",
    "port": 80,
    "use_https": false,
    "timeout_seconds": 60,
    "api_root": "redfish/v1",
    "ssh": {
      "hostname": "<BMC_hostname/IP>",
      "username": "...",
      "password": "...",
      "port": 22
    }
  }
}

Sample amc_redfish_diag_plugin_config.json:

{
  "name": "AmcRedfishDiagnostics",
  "desc": "Collect AMC Manager and System diagnostic bundles through BMC SSH proxy",
  "global_args": {},
  "plugins": {
    "AmcRedfishDiagPlugin": {
      "collection": true,
      "analysis": true,
      "collection_args": {
        "manager_ids": [],
        "system_ids": [],
        "collections": [
          {
            "root": "Managers",
            "diagnostic_data_type": "Manager"
          },
          {
            "root": "Systems",
            "diagnostic_data_type": "OEM",
            "oem_data_type": "AllLogs"
          }
        ],
        "task_timeout_s": 1800
      },
      "analysis_args": {
        "require_all_success": true
      }
    }
  },
  "result_collators": {}
}

Run:

node-scraper  --connection-config ~/configs/connection_config.json   --plugin-config  amc_redfish_diag_plugin_config.json

@amd-ansonyim amd-ansonyim left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing but other that LGTM

Comment thread nodescraper/plugins/ooband/amc_redfish_diag/amc_diag_collector.py Outdated
@amd-ansonyim
amd-ansonyim self-requested a review September 29, 2026 15:26
@alexandraBara
alexandraBara merged commit c360764 into development Sep 29, 2026
7 checks passed
@alexandraBara
alexandraBara deleted the alex_proxy branch September 29, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants