Skip to content

Upgrade to AppFunctions 1.0.0-alpha10#24

Merged
keyboardsurfer merged 5 commits into
mainfrom
bw/alpha10
Jul 9, 2026
Merged

Upgrade to AppFunctions 1.0.0-alpha10#24
keyboardsurfer merged 5 commits into
mainfrom
bw/alpha10

Conversation

@keyboardsurfer

Copy link
Copy Markdown
Member

• Upgraded both agent and ChatApp modules to AppFunctions 1.0.0-alpha10.
• Refactored exception handling in AgentOrchestrator to act on errors directly instead of surfacing them as unhandled exceptions.
• Cleaned up obsolete repository classes and refactored base service architectures.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the application to the new androidx.appfunctions version 1.0.0-alpha10 architecture, replacing the legacy configuration with the new AppFunctionService entry points. It introduces BaseChatAppFunctionService, BaseBuiltInAppFunctionService, and BaseFakeAppFunctionService, registers them in the manifests, and adds AppFunctionExceptionFormatter to format exceptions for LLM outputs. Feedback focuses on ensuring cooperative coroutine cancellation by rethrowing CancellationException instead of swallowing or wrapping it in BaseChatAppFunctionService and AgentOrchestrator. Additionally, it is recommended to avoid using reflection with Class.forName when launching MainActivity in BaseChatAppFunctionService.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ChatApp/wear/build.gradle.kts Outdated
Comment thread agent/app/src/main/AndroidManifest.xml Outdated
Comment thread ChatApp/shared/src/main/kotlin/com/example/chatapp/appfunctions/AppFunctions.kt Outdated
- Re-throw CancellationException in BaseChatAppFunctionService and AgentOrchestrator to preserve cooperative coroutine cancellation.
- Replace reflection (Class.forName) with Intent.setClassName for MainActivity resolution.
- Remove legacy mock-based AppFunctionsTest in favor of E2E AppFunctionInstrumentationTest.
- Update targetApi to 37 for multiple AppFunction services in agent AndroidManifest.xml.
- Bump wear module minSdk to 36 and remove redundant @RequiresApi annotations.
- Rename appException to appFunctionException in AgentOrchestrator.
- Remove obsolete AppFunctionManager null-check test in ExecuteAppFunctionUseCaseTest.
- Replace inline FQCN usages for PendingIntent, UUID, and CancellationException with imports.
- Remove manual AppFunctionsIds object in favor of KSP-generated ChatAppFunctionService function ID constants in instrumentation tests and view models.
@keyboardsurfer keyboardsurfer merged commit a450d67 into main Jul 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants