Repository navigation
fix(@angular/build): filter Rolldown warnings and disable .d.ts annotation comments in library builder - #34313
Merged
alan-agius4 merged 2 commits intoOct 12, 2026
Conversation
…ation comments in library builder Suppress noisy Rolldown warnings (`EMPTY_BUNDLE`, `UNUSED_EXTERNAL_IMPORT`, and `THIS_IS_UNDEFINED`) and disable annotation comments in `.d.ts` output bundles to match `ng-packagr` behavior.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Rolldown bundler configuration to ignore specific warning codes ('EMPTY_BUNDLE', 'UNUSED_EXTERNAL_IMPORT', 'THIS_IS_UNDEFINED') and adjusts the comment preservation settings to ensure JSDoc comments are kept in .d.ts files while annotation comments are excluded. Corresponding tests were added to verify the suppression of 'EMPTY_BUNDLE' warnings and the correct handling of comments. I have included a suggestion to further strengthen the test case by explicitly asserting that annotation comments are absent from the .d.ts output.
alan-agius4
added
action: review
…s annotation comments in library builder
clydin
approved these changes
Oct 12, 2026
alan-agius4
added
action: merge
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppress noisy Rolldown warnings (
EMPTY_BUNDLE,UNUSED_EXTERNAL_IMPORT, andTHIS_IS_UNDEFINED) and disable annotation comments in.d.tsoutput bundles to matchng-packagrbehavior.