fix(acp): show real tool context in permission prompt title#33950
Open
bcdady wants to merge 1 commit into
Open
fix(acp): show real tool context in permission prompt title#33950bcdady wants to merge 1 commit into
bcdady wants to merge 1 commit into
Conversation
- fix(acp): use tool description as title in permission prompts and tool call updates - fix(acp): surface file path and tool context in permission prompt titles
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33949
Type of change
What does this PR do?
ACP permission prompts currently set their title to
permission.permission(the tool kind: "bash", "edit", "webfetch", etc.). The user has to expand the dialog to see what they're actually being asked to approve.This adds a fallback chain through
permission.metadataso the title reflects the real context:description → command → filepath → filePath → pattern → url → repository → path → kindrawInputis unchanged (still the full metadata object), so the expanded view keeps every field.How did you verify your code works?
Tested locally in Zed under ACP. Bash approval prompts now show the command string; edit/write prompts show the file path; webfetch prompts show the URL.
Screenshots / recordings
Before: prompt title says
bashAfter: prompt title says e.g.
git statusormv old.txt new.txtChecklist