fix(core): preserve provider session failures#34015
Open
kitlangton wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.next.step.failedeventsThis is the current-
devsuccessor to the closed #33760.Safety
The durable error contains only a category, stable user-facing message, optional numeric status, retryability, and optional retry delay. Provider response bodies, headers, request URLs, request IDs, credentials, metadata, and raw messages are not persisted.
Failed turns continue to strip provider-native continuation metadata through the existing Session history lowering behavior; that implementation is unchanged here.
Verification
git diff --check@agents/agenttypecheck and observer/embedded integration tests: 6 passed against this checkoutThe full Core suite passed 1025 tests and hit one unrelated existing macOS watcher failure:
.git/HEADwas reported asaddwhere the test expectschange; it reproduces standalone.