fix(sdk): wake embedded session live tail#34017
Open
kitlangton wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.next.step.failedon the still-open streamThis is the current-
devintegration of the reviewed work from #34008. It has no dependency on continuation defaults, provider-error typing, or #34010.Verification
packages/sdk-next: bun run test(4 passed)packages/core: bun run test test/event.test.ts test/session-prompt.test.ts test/session-run-coordinator.test.ts(90 passed)packages/client: bun run check:generated && bun run test(9 passed)packages/sdk/js/script/build.ts) produced no additional diffbun run typecheck(29 packages passed)bun run lint(0 errors; existing warnings only)bunx prettier --check $(git diff --name-only origin/dev)git diff --checkFull Core suite: 1031 passed; one unrelated macOS watcher assertion failed because
.git/HEADwas reported asaddinstead of expectedchange(test/filesystem/watcher.test.ts). The same isolated watcher test reproduces the failure.