fix(llm): omit stateless response item ids#34027
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
store: falseitem_referencecontinuations when storage is enabledRationale
The Open Responses input schema makes
ReasoningItemParam.idoptional, whileItemReferenceParam.idremains required. OpenAI Codex follows that distinction by skipping response item IDs during normal request serialization and only attaching them for its stateful Azure path.Stateless continuations already carry
reasoning.encrypted_content, so they should replay the complete item without asserting the identity of a provider-stored item. This complements #34013, which selects encrypted replay for catalog OpenAI models.Tests
bun run test test/provider/openai-responses.test.ts test/tool-runtime.test.ts: 78 passedbun run test: 281 passed, 30 skippedbun typecheckbunx prettier --check packages/llm/src/protocols/openai-responses.ts packages/llm/test/provider/openai-responses.test.ts packages/llm/test/tool-runtime.test.tsbunx oxlint packages/llm/src/protocols/openai-responses.ts packages/llm/test/provider/openai-responses.test.ts packages/llm/test/tool-runtime.test.ts: zero errors, one pre-existing warning in unchanged test codegit diff --check