fix(core): handle aborted overflow compaction#34029
Open
cwj2001 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #27924
Type of change
What does this PR do?
Handles aborted overflow recovery compaction without re-entering the compaction loop.
When the provider reports context overflow before assistant output, OpenCode tries to summarize and retry once. If that summary stream aborts or dies with a non-interrupt failure, this PR treats the summary as failed and persists the original provider overflow as the assistant error.
Real user/session interrupts still propagate as interrupts.
How did you verify your code works?
bun test test/session-runner.test.ts --test-name-pattern "publishes the original overflow when recovery summarization aborts"frompackages/corebun test test/session-runner.test.ts --test-name-pattern "overflow"frompackages/corebun typecheckfrompackages/corebun turbo typecheck: 29 successful, 29 totalScreenshots / recordings
N/A. Core session recovery fix.
Checklist