fix(session): stop malformed tool-call loops#34039
Open
Nomadcxx wants to merge 1 commit into
Open
Conversation
9814246 to
fc9c86d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #31247
Type of change
What does this PR do?
Copilot Claude Opus 4.8 can return
finish=tool-callswithout sending a structured tool call. OpenCode treated that as a tool-loop turn and asked the provider again, which can lead to Copilot rejecting the next request as assistant prefill.This PR stops the loop when that malformed response shape appears. It records a session
APIError, marks the assistant turn asfinish=error, publishes the existing session error event, and leaves valid tool-call turns unchanged.How did you verify your code works?
Observed:
From repo root:
Observed:
Screenshots / recordings
Not applicable. This PR changes session-loop behavior, not UI.
Checklist