ci: pin third-party actions to commit SHAs#362
Open
postalservice14 wants to merge 1 commit into
Open
Conversation
Tag and branch refs are mutable; pinning third-party actions to full commit SHAs (with the version preserved in a trailing comment) follows GitHub's recommended hardening and guards against supply-chain compromise such as the reviewdog incident. CI-only, no change to entrypoint.sh behavior. Existing versions are preserved (softprops pinned to the 2.0.0 SHA, not bumped). Addresses anothrNick#336.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Pins every third-party GitHub Action used in the
lint,testandmain(release)workflows to a full commit SHA, keeping the human-readable version in a trailing comment:
actions/checkout@v4→@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4reviewdog/action-shellcheck@v1→@4c07458293ac342d477251099501a718ae5ef86e # v1reviewdog/action-hadolint@v1→@921946a7ebaaf08ac72607bad67209f4e52b5407 # v1reviewdog/action-actionlint@v1→@6fb7acc99f4a1008869fa8a0f09cfca740837d9d # v1bats-core/bats-action@3.0.1→@42fcc8700f773c075a16a90eb11674c0318ad507 # 3.0.1softprops/action-gh-release@v2.0.0→@a6c7483a42ee9d5daced968f6c217562cd680f7f # v2.0.0Tag and branch refs are mutable; pinning to commit SHAs is GitHub's
recommended hardening
and guards against supply-chain compromise such as the reviewdog incident (#336).
The local
uses: ./self-references andanothrNick/github-tag-action@masterare leftas-is (intentional per the comments in
main.yml).Breaking Changes
Do any of the included changes break current behaviour or configuration?
NO — CI-only. No change to
entrypoint.sh,action.ymlorDockerfile. Versions arepreserved, not upgraded (e.g.
softpropsis pinned to the existing 2.0.0 SHA).How changes have been tested
actionlintlocally: the only findings are pre-existing shellcheck notes inside thetest.ymlinline script (SC2086 etc.) — none are on the changeduses:lines and noneare introduced by this PR.
List any unknowns
softprops/action-gh-releaseis pinned to the existing 2.0.0 SHA rather than bumped.Dependabot PR Bump softprops/action-gh-release from 2.0.0 to 2.0.8 #321 separately proposes bumping it to 2.0.8 — these don't conflict, but the
two could be folded together if maintainers prefer.