docs(skills): sync & improve all simple-module agent skills - #220
Merged
Conversation
Add package-update section, smpy new --flat, sync-js-deps --dry-run, the background_tasks recipe, the simple-module alias, and the built-in vs plugin-subgroup distinction. Correct the scaffold-name examples (smpy new rejects mixed case) and clarify the wizard-only custom preset. Claude-Session: https://claude.ai/code/session_01RZW4T5eFvrZoDLuN1mHg47
Deploying simple-module-python with
|
| Latest commit: |
ce84d3e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e6666af1.simple-module-python.pages.dev |
| Branch Preview URL: | https://worktree-cli-skill-update.simple-module-python.pages.dev |
Audit-and-improve pass across the remaining nine skill packs (CLI skill
done separately), each change verified against live source:
- database: AuditMixin created_at is Python-side; MultiTenantMixin hard-fails
(TenantIsolationError, non-null tenant_id).
- migrations: correct host/ paths, make migration/migrate, `upgrade heads`
(plural), env.py render_item/process_revision_directives, single-shared-schema
note, unlabeled bootstrap-revision exception.
- registries: drop the false permission-cache TTL claim (invalidates on
mutation), fix the event-bus pitfall mechanism, register_event_handlers(bus,
app) signature, prefer Depends(require_flag()).
- doctor: only SM001 fails prod boot (diagnostics are dev-gated); make doctor
mechanics; SM010/011 firing conditions; real output format.
- creating: make new-module over raw commands, full scaffold tree,
register_public_routes, aligned module.py template.
- inertia-pages: i18n prop shape {locale,supportedLocales,messages}, correct
principal_serializer (auth module), SM018 Inertia-native fix, SM019.
- testing: vitest include scope, perf marker, scaffold test filename.
- conventions: add invalid-assignment to the ty-ignore list.
- locales: document the backend TranslatorDep / t.t() API.
README verified already-accurate (unchanged).
Claude-Session: https://claude.ai/code/session_01RZW4T5eFvrZoDLuN1mHg47
antosubash
changed the title
Code-review (Stage A) caught sibling skills still carrying the old "errors fail prod boot" framing after the doctor skill was corrected to "diagnostics run dev-only; only strict discovery (SM001) fails prod boot": - creating: diagnostics are dev-only (raise SystemExit); prod boot only fails on strict discovery (SM001). SM008/SM009 are dev-boot/make-doctor errors, not prod-boot blockers. - migrations: SM010/SM011 are emitted only by run_diagnostics(migration_state= /module_tables=), not at boot or by make doctor; the boot guard is check_migrations() raising RuntimeError in both dev and prod. - locales: SM016 fails dev boot / make doctor; prod skips the diagnostics pass. (register_public_routes, flagged as "fabricated" by one verifier, was confirmed real in source — module.py:122 / app_builder.py:238 — and left as-is.) Claude-Session: https://claude.ai/code/session_01RZW4T5eFvrZoDLuN1mHg47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A full accuracy-and-improvement pass over the bundled
simple-module-*agent skills inskills/, bringing every pack back in sync with the current codebase. Two commits:simple-module-cli— documents newsmpyCLI surface:package-update,new --flat,sync-js-deps --dry-run, thebackground_tasksrecipe, thesimple-modulealias, built-in vscli_pluginsplugin subgroups; corrects the scaffold-name examples (smpy newrejects mixed case) and the wizard-onlycustompreset.AuditMixin.created_atis Python-side;MultiTenantMixinhard-fails (TenantIsolationError, non-nulltenant_id)host/paths,make migration/make migrate,upgrade heads(plural),env.pyrender_item/process_revision_directives, single-shared-schema note, unlabeled bootstrap-revision exceptionregister_event_handlers(bus, app)signature,Depends(require_flag())over the legacy decoratormake doctormechanics, SM010/011 firing conditions, real output format; full SM001–SM021 setmake new-moduleover raw commands, full scaffold tree,register_public_routes, alignedmodule.pytemplate{locale, supportedLocales, messages}, correctprincipal_serializer(auth module), SM018 Inertia-native fix, SM019includescope,perfmarker, scaffold test filenameinvalid-assignmentto the ty-ignore listTranslatorDep/t.t()APIskills/README.mdwas verified already-accurate (no change).How it was produced
One audit agent per skill, each verifying every factual/behavioral claim against the live source it documents (
framework/,modules/,host/,Makefile,pyproject.toml,docs/). Edits are minimal and evidence-cited; voice/structure preserved.Verification
.py/.ts/.tsxchanged.Test plan
smpy skills listrenders every skill's description cleanly.https://claude.ai/code/session_01RZW4T5eFvrZoDLuN1mHg47