Skip to content

Serve logs from scheduler if any executor is LocalExecutor #71283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
topherinternational wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Serve logs from scheduler if any executor is LocalExecutor #71283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions airflow-core/src/airflow/cli/commands/scheduler_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,11 @@ def _serve_logs(skip_serve_logs: bool = False):

sub_proc = None
if skip_serve_logs is False:
executor_class, _ = ExecutorLoader.import_default_executor_cls()
if executor_class.serve_logs:
executor_classes = [
ExecutorLoader.import_executor_cls(executor_name)[0]
for executor_name in (ExecutorLoader.get_executor_names())
]
if any(executor_class.serve_logs for executor_class in executor_classes):
sub_proc = Process(target=serve_logs)
sub_proc.start()
try:
Expand Down
2 changes: 2 additions & 0 deletions airflow-core/tests/unit/cli/commands/test_scheduler_command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ def setup_class(cls):
("CeleryExecutor", False),
("LocalExecutor", True),
("KubernetesExecutor", False),
("LocalExecutor,KubernetesExecutor", True),
("KubernetesExecutor,LocalExecutor", True),
],
)
@mock.patch("airflow.cli.commands.scheduler_command.SchedulerJobRunner")
Expand Down