Repository navigation
fix(csharp): return true from AdbcDataReader.IsDBNull for null values - #4920
Merged
Merged
Conversation
GetValue returns DBNull.Value for null values, but IsDBNull compared its result to null, so it always returned false. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
AdbcDataReader.IsDBNullcheckedGetValue(ordinal) == null, butGetValuereturnsDBNull.Valuefor null values, soIsDBNullalways returnedfalse. It now checks forDBNull.It still goes through
GetValue, so a value supplied by anOnGetValuehandler continues to count as not null.Found while working on #4919.
Tests
TestIsDBNullreads a column whose fourth row is null and checksIsDBNullfor every row.🤖 Generated with Claude Code