Repository navigation
test(csharp): test NaN and infinity in variant values - #4922
Merged
Merged
Conversation
Variants converted to JSON use the same writer as structs, which writes non-finite floats and doubles as strings since apache#4921. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed
Adds the variant test promised in #4919. Variants converted to JSON use the same writer as structs, so they already get the behavior from #4921: NaN and ±Infinity are written as the strings
"NaN","Infinity"and"-Infinity". This test pins that down.VariantNonFiniteValuesreads a variant column with a non-finite double and float inside an object and an array, and a top-level NaN:StructBehavior.JsonString, it checks the exact JSON.StructBehavior.Strict, it checks that the .NET values keep the actual NaN and infinity values.With the #4921 change reverted, the JSON case fails with the original
ArgumentException.🤖 Generated with Claude Code