perf(parquet): use typed memo insertion for fixed-width dictionaries - #1312
Open
fallintoplace wants to merge 1 commit into
Open
perf(parquet): use typed memo insertion for fixed-width dictionaries#1312fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
These encoders already use the binary memo table, but still called GetOrInsert through the generic interface for every value. The typed entry point avoids the extra interface conversion. Dictionary order and encoded output stay unchanged.
Benchmark
Apple M1 Pro, macOS arm64, Go 1.26.3. 65,535 values and 100 unique values, median of five runs.
Allocated bytes also fell by about 42% for FLBA and 33% for Int96.
Tests