bench(parquet): add same-projection predicate chain benchmark - #11007
Open
haohuaijin wants to merge 1 commit into
Open
bench(parquet): add same-projection predicate chain benchmark#11007haohuaijin wants to merge 1 commit into
haohuaijin wants to merge 1 commit into
Conversation
Add a criterion benchmark for RowFilter chains whose predicates share one projection. It scans an in-memory Snappy Parquet file of 262,144 rows through the async reader and covers int64 and string filter columns in fragmented and clustered layouts, with the filter column either projected (predicate cache) or not, chains of one, two and four predicates, and survivor profiles that keep 99% or 50% per predicate or 1% in the first or last predicate. A selection_boundary group probes run lengths around the row selection policy threshold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #10926.
Rationale for this change
RowFilterevaluates eachArrowPredicateseparately, so consecutive predicates on the same projection decode that column, or replay it from the predicate cache, once per predicate. #10859 fuses such chains. Per the contributing guide, the benchmark is submitted separately so it can run on the automated runner and serve as the baseline for that change.What changes are included in this PR?
A criterion benchmark,
parquet/benches/arrow_reader_predicate_fusion.rs, that scans an in-memory Snappy Parquet file of 262,144 rows through the async reader. Case names aretype/layout/cache/predicates/profile:int64/stringfilter column,fragmented(one key per row) orclustered(each key repeated for 128 rows)cached/uncached: whether the filter column is also projected and therefore served by the predicate cacheall99,all50,early1andlate1selection_boundarygroup with run lengths 16, 32 and 64 around the default row selection policy threshold75 cases in total. Each case is validated once outside measurement for the expected row count and predicate cache use.
Are these changes tested?
The benchmark builds and its registration-time validation passes on
main.Are there any user-facing changes?
No.