Skip to content

feat(arrow-cast): move map cast tests to integration suite - #11041

Open
codewarnab wants to merge 2 commits into
apache:mainfrom
codewarnab:issue-11033-split-cast-tests
Open

feat(arrow-cast): move map cast tests to integration suite#11041
codewarnab wants to merge 2 commits into
apache:mainfrom
codewarnab:issue-11033-split-cast-tests

Conversation

@codewarnab

Copy link
Copy Markdown

Which issue does this PR close?

Part of #11033.

Rationale for this change

The public-behavior cast tests in arrow-cast/src/cast/mod.rs are being moved into a crate-level integration test suite so individual cast families are easier to locate and maintain. This is the map-test slice of that work.

What changes are included in this PR?

  • Adds the arrow-cast cast integration-test target.
  • Adds arrow-cast/tests/cast/.
  • Moves the four map cast tests from the inline cast/mod.rs test module to tests/cast/map.rs.

Are these changes tested?

  • cargo test -p arrow-cast --test cast
  • cargo fmt --all -- --check

A targeted Clippy run is blocked by existing arrow-data warnings under the locally installed Clippy version.

Are there any user-facing changes?

No. This is a test-organization-only change.

AI usage disclosure

OpenAI Codex assisted with the mechanical test extraction. I reviewed the resulting changes and verified the targeted tests locally.

Copilot AI lite review requested due to automatic review settings September 9, 2026 17:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added arrow Changes to the arrow crate arrow-cast labels Sep 9, 2026

@sdf-jkl sdf-jkl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codewarnab LGTM.

@Jefffrey please take a look at the proposed split and lmk if you agree with the direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-cast

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants