GH-49967: [Python][CI] Raise oldest NumPy wheel-test requirement to a patched release#49965
GH-49967: [Python][CI] Raise oldest NumPy wheel-test requirement to a patched release#49965arpitjain099 wants to merge 1 commit into
Conversation
Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
raulcd
left a comment
There was a problem hiding this comment.
Thanks for the PR. Could you follow the contributing guidelines for the project and open a corresponding issue
|
|
|
|
|
@raulcd please review the PR when you can. I added corresponding issue as you asked. Thank you! |
There was a problem hiding this comment.
Hi @arpitjain099, just so I understand this better, dependabot flags this dependency as a security issue or what is the exact problem?
There's also this discussion which maybe instead of bumping individual patch releases for numpy we could potentially bump to numpy 2, see:
Also this is just for the minimal test requirements, is there a reason you are using requirements-wheel-test.txt. For build we already have a minimum numpy of >=1.25
I basically want to understand the case you are flagging
|
@raulcd answers to each:
Let me know which direction you'd prefer. |
|
@github-actions crossbow submit wheel-310 |
|
Revision: 528258b Submitted crossbow builds: ursacomputing/crossbow @ actions-52d25f49e0 |
raulcd
left a comment
There was a problem hiding this comment.
Ok, thanks for the comment. To be honest feels like a minor issue to me. We just use those to specify the minimum version we can be compatible with on testing but we build with a more modern version.
I am running tests for the wheels, which is the only place we use this requirements file on testing, and we can bump it if CI is successful, we are going to drop Python 3.10 support in one release once we add Python 3.15.
Just so I understand, where did you get the dependabot alert? I can't see it in the Arrow repo security alerts.
Thanks
|
@raulcd the alert is on my fork (Dependabot enabled there): https://github.com/arpitjain099/arrow/security/dependabot/1. apache/arrow's own security tab may not surface this specific file or this Dependabot bucket, which would explain why it isn't visible to you. The advisory is a global GitHub one: GHSA-fpfv-jqm9-f5jm / CVE-2021-34141 against Agree the practical impact is small given this is only the wheel-test lower bound and the actual build uses |
528258b to
7847066
Compare
Summary
python/requirements-wheel-test.txtfor Python<3.11fromnumpy~=1.21.3tonumpy~=1.22.0.Why
Dependabot flags
numpy < 1.22in this requirements file. Bumping the lower compatible test constraint to the patched line addresses the advisory while preserving the existing per-Python version strategy.Validation
python3 -m pip install -r python/requirements-wheel-test.txt