GH-49974: [C++][CMake] Add missing result variable initialization for validate_apple_libtool()#49975
Open
kou wants to merge 1 commit into
Open
GH-49974: [C++][CMake] Add missing result variable initialization for validate_apple_libtool()#49975kou wants to merge 1 commit into
validate_apple_libtool()#49975kou wants to merge 1 commit into
Conversation
`find_package()`'s `VALIDATOR`'s result variable must be initialized to `TRUE` by caller.
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a macOS CMake configuration bug where explicitly setting -DCMAKE_LIBTOOL=... could fail validation because the VALIDATOR result variable wasn’t initialized before calling validate_apple_libtool().
Changes:
- Initialize
is_apple_libtooltoTRUEbefore invokingvalidate_apple_libtool()whenCMAKE_LIBTOOLis explicitly provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
find_package()'sVALIDATOR's result variable must be initialized toTRUEby caller.We reuse the
VALIDATOR(validate_apple_libtool()) when we specifyCMAKE_LIBTOOLexplicitly. But we didn't initialize the result variable toTRUE.What changes are included in this PR?
Initialize
is_apple_libtoolexplicitly.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.