[AURON #2301] Upgrade hashbrown to 0.17.1 and adapt API#2302
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Rust dependency hashbrown from 0.14.5 to 0.17.1 and updates the AccSet implementation to use the newer hash table API in the native DataFusion extension plans.
Changes:
- Bumped
hashbrowncrate version to0.17.1(and updated the lockfile accordingly). - Replaced
hashbrown::raw::RawTableusage withhashbrown::HashTableand adapted insertion/find logic. - Removed prior
unsafeinsertion flow (insert_in_slot) in favor of the newer safeinsert_uniqueworkflow guarded by an explicitfind.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| native-engine/datafusion-ext-plans/src/agg/collect.rs | Adapts internal set implementation from RawTable to HashTable and updates uniqueness-check/insertion logic. |
| Cargo.toml | Updates hashbrown dependency version to 0.17.1. |
| Cargo.lock | Locks hashbrown to 0.17.1 and records new transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
richox
approved these changes
Jun 3, 2026
SteNicholas
approved these changes
Jun 3, 2026
yew1eb
approved these changes
Jun 3, 2026
merrily01
approved these changes
Jun 4, 2026
Member
|
Merged. @cxzl25 Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2301
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?
GHA