Allow 'all' on security group rule protocol#294
Open
bddvlpr wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for using protocol = "all" in cloudstack_security_group_rule, aligning provider validation/behavior with the documented allowed values and closing #274.
Changes:
- Create security group rules when
protocolis set to"all". - Read back
"all"protocol rules into state. - Extend acceptance test configs/assertions to include
"all"protocol rules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cloudstack/resource_cloudstack_security_group_rule.go | Adds create/read/validation handling for protocol = "all" on security group rules. |
| cloudstack/resource_cloudstack_security_group_rule_test.go | Updates acceptance tests to exercise the new "all" protocol behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bddvlpr
force-pushed
the
fix/allow-all-sg
branch
from
f8de2e5 to
01c7717
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting "all" as the protocol for security group rules.
Closes #274.