vmware: do not check secondary storage and attach ISO when start a system vm#13031
Open
weizhouapache wants to merge 2 commits into
Open
vmware: do not check secondary storage and attach ISO when start a system vm#13031weizhouapache wants to merge 2 commits into
weizhouapache wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13031 +/- ##
=========================================
Coverage 17.69% 17.69%
+ Complexity 15833 15830 -3
=========================================
Files 5925 5925
Lines 533534 533510 -24
Branches 65273 65267 -6
=========================================
+ Hits 94394 94409 +15
+ Misses 428463 428422 -41
- Partials 10677 10679 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| i++; | ||
| } else if (!deployAsIs) { | ||
| if (VirtualMachine.Type.User.equals(vmSpec.getType()) && !deployAsIs) { | ||
| // Note: we will always plug a CDROM device |
Contributor
There was a problem hiding this comment.
Test comment 1. PR 13031
weizhouapache
marked this pull request as ready for review
July 17, 2026 13:21
Contributor
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 18623 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unnecessary check on secondary storage and ISO attachment when start a system vm on vmware.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?