Allow Domain Admins to provide custom Id for Resource (VM, Volume, etc) creation commands.

[sureshanaparti]

Description

This PR allows Domain Admins to provide custom Id for Resource (VM, Volume, etc) creation commands.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.69%. Comparing base (5328528) to head (dc65e5c).
⚠️ Report is 1 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/uuididentity/UUIDManagerImpl.java	0.00%	13 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #13850      +/-   ##
============================================
- Coverage     17.69%   17.69%   -0.01%     
+ Complexity    15835    15831       -4     
============================================
  Files          5925     5925              
  Lines        533539   533549      +10     
  Branches      65274    65276       +2     
============================================
- Hits          94427    94420       -7     
- Misses       428435   428453      +18     
+ Partials      10677    10676       -1     

Flag	Coverage Δ
uitests	3.69% <ø> (ø)
unittests	18.77% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18829

[DaanHoogland]

clgtm, one caveat (about the old code, not the new); a UUID should be universally unique. Right now only uniqueness for its own entity type is checked.

[vladimirpetrov]

LGTM based on manual testing with admin, domain admin (VMs and volumes) and negative tests with regular user, invalid and duplicated custom ids.

[vladimirpetrov]

@blueorangutan test

[blueorangutan]

@vladimirpetrov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests