feat: Implement state conversion for remaining group accumulators#23275
Open
lyne7-sc wants to merge 2 commits into
Open
feat: Implement state conversion for remaining group accumulators#23275lyne7-sc wants to merge 2 commits into
lyne7-sc wants to merge 2 commits into
Conversation
github-actions
Bot
added
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GroupsAccumulator::supports_convert_to_stateand makeconvert_to_statemandatory #23081.Rationale for this change
#23081 proposes making
GroupsAccumulator::convert_to_statemandatory and removingsupports_convert_to_state.Before that API cleanup can happen, all existing
GroupsAccumulatorimplementations need a correctconvert_to_stateimplementation.This PR is the first step toward that cleanup: it fills in missing
convert_to_stateimplementations for the remaining group accumulators that currently participate in grouped aggregation.What changes are included in this PR?
This PR adds
convert_to_statesupport for:PrimitiveDistinctCountGroupsAccumulatorHllGroupsAccumulatorforapprox_distinctVarianceGroupsAccumulatorStddevGroupsAccumulatorCorrelationGroupsAccumulatorGeometricMeanGroupsAccumulatorin the advanced UDAF exampleAre these changes tested?
Yes. This PR adds unit tests for the new
convert_to_stateimplementations.Are there any user-facing changes?
No. This PR does not remove
supports_convert_to_stateyet and does not change the publicGroupsAccumulatorAPI.