Repository navigation
fix(docs): Fix code snippet in LogicalPlan docs - #25377
Merged
Merged
Conversation
https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.LogicalPlan.html#visiting-and-rewriting-logicalplans The comment says `// Projection(name, salary)` but the code does `project(vec![col("name")])?`. It should include the `col("salary")` too
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #25377 +/- ##
==========================================
- Coverage 81.94% 81.93% -0.02%
==========================================
Files 1135 1136 +1
Lines 428278 428677 +399
Branches 428278 428677 +399
==========================================
+ Hits 350952 351219 +267
- Misses 56369 56442 +73
- Partials 20957 21016 +59 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nuno-faria
approved these changes
Sep 16, 2026
Member
Author
|
Thank you for the review, @nuno-faria ! |
Omega359
pushed a commit
to Omega359/arrow-datafusion
that referenced
this pull request
Oct 11, 2026
## Which issue does this PR close? Closes N/A. ## Rationale for this change See https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.LogicalPlan.html#visiting-and-rewriting-logicalplans The comment says `// Projection(name, salary)` but the code does `project(vec![col("name")])?`. It should include the `col("salary")` too ## What changes are included in this PR? The code snippet in the docstring is fixed to match the plan in the comments. ## What is the testing strategy for this PR? Build the docs and verify that the code snippet matches the comments above it. ## Are there any user-facing changes? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes N/A.
Rationale for this change
See https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.LogicalPlan.html#visiting-and-rewriting-logicalplans
The comment says
// Projection(name, salary)but the code doesproject(vec![col("name")])?. It should include thecol("salary")tooWhat changes are included in this PR?
The code snippet in the docstring is fixed to match the plan in the comments.
What is the testing strategy for this PR?
Build the docs and verify that the code snippet matches the comments above it.
Are there any user-facing changes?
No.