FINERACT-2572: Exclude license-incompatible libraries from distributi…#5899
FINERACT-2572: Exclude license-incompatible libraries from distributi…#5899SamaSVM wants to merge 1 commit into
Conversation
6941b83 to
5aac227
Compare
|
@SamaSVM, would you like to move this PR and discussion to the Fineract DEV email list? These changes have a significant impact, and we should discuss and observe their effects on the DEV email list. |
5aac227 to
dceed02
Compare
meonkeys
left a comment
There was a problem hiding this comment.
Thanks for this patch and for starting the dev list discussion, Vlad! Thank you Ádám and @Aman-Mittal for your feedback.
I generated a binary release tarball artifact with the binaryDistTar task and it looked good (no category X jars included).
These instructions are now wrong. Will you update fineract-doc/src/docs/en/chapters/release/process-step09.adoc? Build a binary release artifact and Docker image locally, test those, and let me know how it goes.
Finally, will you try the generateLicenseReport task? I wonder if we want to manually exclude the jars we are no longer packaging, or if it can do that automatically. I see some are marked "Not Packaged" but I don't understand what that means.
dceed02 to
4187471
Compare
I've verified the "Build a binary release artifact and Docker image locally", and everything looks good — no Category X jars are included. I've also updated fineract-doc/src/docs/en/chapters/release/process-step09.adoc, please check. I have some difficulties running 'generateLicenseReport' locally, but I'll continue working it. |
I've generated the generateLicenseReport report, which contains 349 libraries. I also noticed that some of them are marked as "Not Packaged" in the Manifest License column. During my investigation of the implementation (specifically the printDependencyManifest method in InventoryReportRenderer.groovy), I found that the "Not Packaged" label simply indicates that the license text is not physically embedded within the JAR file. |
|
Awesome, thanks for the updates and research. The code and docs updated LGTM, I just want to test building & running myself with these new defaults before I approve. I'll do it asap. |
Description
Resolves the ASF Category X license violation by excluding LGPL/GPL libraries from all Fineract distribution artifacts (binary tarball, WAR, bootJar, Docker image).
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.