FINERACT-2620: Add type-safe Feign-based helpers and integration tests for the Savings domain

[DeathGun44]

Description

Adds Feign-based helpers and integration tests for the Savings domain — mirrors the existing Loan test infrastructure.

New files

File	Purpose
FeignTestConstants	Shared date format and locale constants across test domains
FeignSavingsProductHelper	Create and retrieve savings products
FeignSavingsHelper	Account lifecycle: submit, approve, activate, close, query, delete
FeignSavingsTransactionHelper	Deposit and withdrawal operations
SavingsTestData	Savings-specific constants (interest types, accounting rules, statuses)
SavingsRequestBuilders	Typed request object factories
FeignSavingsTestBase	Abstract base wiring all helpers together
FeignSavingsLifecycleExtension	JUnit 5 cleanup extension with idempotent teardown
FeignSavingsLifecycleTest	8 end-to-end tests covering the full savings lifecycle

Modified files

File	Change
LoanTestData	Delegates DATETIME_PATTERN and LOCALE to FeignTestConstants (source-compatible)

Notes

• Pure Feign throughout — no RestAssured or Retrofit imports
• Cleanup extension catches all exceptions so pre-existing accounts on CI don't break test runs
• No changes to existing legacy helpers or tests

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• Write the commit message as per our guidelines
• Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
• Create/update unit or integration tests for verifying the changes made.
• Follow our coding conventions.
• Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
• This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

[budaidev]

do we use this anywhere? What's the role of this field?

[DeathGun44]

removed it. each domain's request builders already use DATETIME_PATTERN via their own *TestData class, so the alias was unnecessary. thank you!

[budaidev]

Strange that we use closedOnDate here, but as I checked it is probably a swagger model problem. Anyway, I don't think it's the right way to send rejectedOnDate on other parameter

[DeathGun44]

this is a limitation of the generated Swagger model. PostSavingsAccountsAccountIdRequest doesn't expose a rejectedOnDate field (only activatedOnDate, approvedOnDate, closedOnDate). the legacy helper works around this by constructing raw JSON with map.put("rejectedOnDate", ...), but that defeats the purpose of type-safe migration. the server accepts closedOnDate for the reject command, and our tests pass. this is a Swagger spec gap worth filing separately so we can improve our tests .thoughts?

[adamsaghy]

final JsonElement element = this.fromApiJsonHelper.parse(json);
        final LocalDate rejectedOnDate = this.fromApiJsonHelper.extractLocalDateNamed("rejectedOnDate", element);
        baseDataValidator.reset().parameter("rejectedOnDate").value(rejectedOnDate).notNull();

Are you sure server accepts it?

[DeathGun44]

No, you were right it doesn't. I traced through SavingsAccountApplicationTransitionApiJsonValidator.validateRejection() and confirmed it rejects closedOnDate as unsupported. My tests only passed because rejectSavings is called in cleanup code wrapped in a try/catch that silently logs the failure. I've filed #5934 to fix the Swagger spec and updated this branch to use .rejectedOnDate() directly. that will be the proper fix!

[adamsaghy]

Lets return the response directly, not just the savingsId.
That would improve the reusability and the data is anyway fetched and returned, we can use it ;)

[DeathGun44]

Done!

[adamsaghy]

Lets return the response object, not just the resourceId.
That would help reusability and the data is fetched anyway.

[DeathGun44]

Done!

[adamsaghy]

Please review my concerns.