Skip to content

FINERACT-2421: Github Actions CI - Clean up ALL artifacts#5930

Draft
adamsaghy wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2421/clean-up-ci-job
Draft

FINERACT-2421: Github Actions CI - Clean up ALL artifacts#5930
adamsaghy wants to merge 1 commit into
apache:developfrom
openMF:FINERACT-2421/clean-up-ci-job

Conversation

@adamsaghy
Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy commented Jun 3, 2026

Description

This is a workflow job which can be triggered manually and it is removing all artifacts.

Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.)

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@adamsaghy adamsaghy requested review from Aman-Mittal and meonkeys June 3, 2026 11:47
@adamsaghy adamsaghy marked this pull request as draft June 3, 2026 12:05
Copy link
Copy Markdown
Contributor

@meonkeys meonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per our chat: Is this necessary, or are expired artifacts auto-deleted?

Please also add an actual description / summary. I'm wondering if this is an optimization, cost savings, or if leaving expired artifacts around will break something

@adamsaghy
Copy link
Copy Markdown
Contributor Author

adamsaghy commented Jun 3, 2026

per our chat: Is this necessary, or are expired artifacts auto-deleted?

Please also add an actual description / summary. I'm wondering if this is an optimization, cost savings, or if leaving expired artifacts around will break something

No, I learned that GitHub automatically removes it when it expires. However, I will rework it to be a standalone option that allows users to remove all artifacts (which can be manually triggered). This will be a good exercise for anyone who is experimenting and wants to remove artifacts to avoid counting them towards artifact usage.

@adamsaghy adamsaghy force-pushed the FINERACT-2421/clean-up-ci-job branch from 756d5f9 to 210d351 Compare June 3, 2026 18:29
@adamsaghy adamsaghy changed the title FINERACT-2421: Github Actions CI - Clean up expired artifacts FINERACT-2421: Github Actions CI - Clean up ALL artifacts Jun 3, 2026
@meonkeys meonkeys dismissed their stale review June 3, 2026 18:31

my question was answered, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants