[FLINK-40514][docs][pipeline-connector/doris] Align Doris pipeline connector option table with implementation - #4561
Merged
Conversation
…nnector option table with implementation
yuxiqian
approved these changes
Sep 28, 2026
yuxiqian
left a comment
Member
There was a problem hiding this comment.
Looks good. Thank you for the nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This is a docs-only fix for FLINK-40514. The Doris pipeline connector option table has drifted from the implementation in both the English and the Chinese docs, so users reading it would get the wrong types and defaults, and six supported options were not documented at all.
Brief change log
auto-redirect: documented asString, but declared asbooleanType()inDorisDataSinkOptions. Corrected toBoolean.charset-encoding: documented asBooleanwith defaultfalse, but declared asstringType()with default"UTF-8". Corrected both the type and the default.\n" + ") that leaked into the Englishsink.ignore.update-beforedescription.DorisDataSinkFactory#optionalOptions()but missing from the table:sink.enable-2pc,sink.check-interval,sink.buffer-size,sink.buffer-count,sink.label-prefixandsink.use-cache. The new rows are appended at the end of thesink.*group, and their descriptions are copied from the correspondingConfigOptiondescriptions.docs/content/docs/connectors/pipeline-connectors/doris.mdanddocs/content.zh/docs/connectors/pipeline-connectors/doris.md.No code change is involved. Existing option descriptions were intentionally left untouched so that this change stays limited to the inaccuracies reported in the JIRA issue.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
The tables were cross-checked against the code: every
ConfigOptiondeclared inDorisDataSinkOptionsnow appears in the option table of both documents, and the only remaining doc entries that have noConfigOptioncounterpart are the pipeline-leveltype/namerows and thesink.properties.*/table.create.*prefix rows.Documentation
Was generative AI tooling used to co-author this PR?
Generated-by: Qoder 1.32.0