Skip to content

[FLINK-38262][table] add CreateConnectionOperation and converter#28158

Open
Shekharrajak wants to merge 1 commit into
apache:masterfrom
Shekharrajak:FLINK-38262-convert-connection-sqlnode-to-operations
Open

[FLINK-38262][table] add CreateConnectionOperation and converter#28158
Shekharrajak wants to merge 1 commit into
apache:masterfrom
Shekharrajak:FLINK-38262-convert-connection-sqlnode-to-operations

Conversation

@Shekharrajak
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Adds CreateConnectionOperation and SqlCreateConnectionConverter to translate SqlCreateConnection AST nodes into executable Operations.

Brief change log

Adds CreateConnectionOperation and SqlCreateConnectionConverter

Verifying this change

unit tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): ( no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: ( no )
  • The runtime per-record code paths (performance sensitive): (no )
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Was generative AI tooling used to co-author this PR?

Yes

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 14, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@Shekharrajak
Copy link
Copy Markdown
Contributor Author

@lihaosky @snuyanzin Please have a look - If these structure looks good, we can have other Operation & converter implemented for the respective SQL AST node.

Followup PRs will have:

DropConnectionOperation, SqlDropConnectionConverter
DropConnectionOperation, SqlDropConnectionConverter
AlterConnectionRenameOperation, SqlAlterConnectionRenameConverter
ShowConnectionsOperation, SqlShowConnectionsConverter
ShowCreateConnectionOperation, SqlShowCreateConnectionConverter
DescribeConnectionOperation, SqlRichDescribeConnectionConverter

Copy link
Copy Markdown
Contributor

@lihaosky lihaosky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shekharrajak for the contribution. I left some comments.

@Shekharrajak Shekharrajak force-pushed the FLINK-38262-convert-connection-sqlnode-to-operations branch from 659c9d7 to 0bb547e Compare May 21, 2026 17:57
@Shekharrajak Shekharrajak force-pushed the FLINK-38262-convert-connection-sqlnode-to-operations branch from 0bb547e to 3f78fab Compare May 21, 2026 18:07
@github-actions github-actions Bot added the community-reviewed PR has been reviewed by the community. label May 22, 2026
@Shekharrajak
Copy link
Copy Markdown
Contributor Author

Please have a look on new changes according to your review @lihaosky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-reviewed PR has been reviewed by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants