[FLINK-40097][historyserver] Introduce Lazy Loading for HistoryServer#28685
Open
chenzihao5 wants to merge 3 commits into
Open
[FLINK-40097][historyserver] Introduce Lazy Loading for HistoryServer#28685chenzihao5 wants to merge 3 commits into
chenzihao5 wants to merge 3 commits into
Conversation
reswqa
reviewed
Jul 10, 2026
|
|
||
| In `LAZY` mode, on-demand fetches use two thread pools: | ||
|
|
||
| * `historyserver.lazy.fetch.executor.common.pool-size` (default: `4`) — The size of the shared thread pool used for routine, background archive fetching. |
Member
There was a problem hiding this comment.
I suggest remove the default value here, because we might forget to sync the documentation when changing default values.
|
|
||
| /** Creates an {@link ArchiveStorage} instance under the given temporary directory. */ | ||
| @FunctionalInterface | ||
| interface ArchiveStorageFactory<T> { |
|
|
||
| /** Creates an {@link ArchiveStorage} instance under the given temporary directory. */ | ||
| @FunctionalInterface | ||
| interface ArchiveStorageFactory<T> { |
| throw new FlinkException("Unsupported archive storage type: " + archiveStorageType); | ||
| } | ||
|
|
||
| Map<String, ArchiveMetaInfo> archiveMetaInfoCache = new HashMap<>(); |
Member
There was a problem hiding this comment.
Is this map thread safe? it's better to check the race condition.
Comment on lines
+166
to
+170
| this.commonFetchExecutor = | ||
| Executors.newFixedThreadPool( | ||
| lazyFetchExecutorCommonPoolSize, | ||
| new ExecutorThreadFactory("HistoryServer-commonFetchExecutor")); | ||
| this.individualFetchExecutor = |
Member
There was a problem hiding this comment.
Where are these two thread pools being shut-down?
|
|
||
| if (!overviewCreated && detailArchives.isEmpty()) { | ||
| archiveMetaInfoCache.remove(jobId); | ||
| throw new RuntimeException("Archive of job " + jobId + " is empty"); |
Member
There was a problem hiding this comment.
This RuntimeException will propagate to the catch (Exception e) block in the scanArchives method. Is this as expected?
|
|
||
| /** Container for the {@link Path} and {@link FileSystem} of a refresh directory. */ | ||
| static class RefreshLocation { | ||
| public static class RefreshLocation { |
Member
There was a problem hiding this comment.
What is the purpose of making these change?
| this.archivePath = archivePath; | ||
| } | ||
|
|
||
| public String getArchiveId() { |
Comment on lines
+536
to
+537
| if (!archiveMetaInfoCache.containsKey(jobId)) { | ||
| archiveMetaInfoCache.put(jobId, new ArchiveMetaInfo(jobId, PENDING, jobArchive)); |
Member
There was a problem hiding this comment.
Is this thread-safe? containsKey + put is not an atomic operation.
I think we should add some comments to declare the thread-safe semantic for archiveMetaInfoCache.
chenzihao5
force-pushed
the
FLINK-40097-lazy-loading-of-hs
branch
from
683fc9f to
1339960
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Introduce a lazy-loading mode that loads archive details on demand, improving archive load times and enhancing the user experience.
Brief change log
historyserver.archive.load.modeto specify the loading mode, supportsEAGER(default) andLAZYhistoryserver.lazy.fetch.executor.common.pool-sizeandhistoryserver.lazy.fetch.executor.individual.pool-sizeto control the loading thread poolPENDING,OVERVIEW_PARSING,OVERVIEW_CREATED,DETAIL_PARSINGin ArchiveEventType.org.apache.flink.runtime.webmonitor.history.AbstractHistoryServerHandler#loadResource.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?