Skip to content

[FLINK-40134][ci] Bump maven-rat-plugin to 0.17#28734

Merged
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:flink40134
Jul 14, 2026
Merged

[FLINK-40134][ci] Bump maven-rat-plugin to 0.17#28734
snuyanzin merged 1 commit into
apache:masterfrom
snuyanzin:flink40134

Conversation

@snuyanzin

@snuyanzin snuyanzin commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

What is the purpose of the change

The PR

  1. bumps maven-rat-plugin to 0.17 version
  2. applies -T1C as now it is thread safe (https://github.com/apache/creadur-rat/blob/86546fd2619401eb92a419488652368eceb878a0/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48)
  3. renames deprecated properties to non deprecated (https://creadur.apache.org/rat/apache-rat/migrationguide/0.17.html)

Brief change log

GHA, pom

Verifying this change

GHA

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes )
  • The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Comment thread pom.xml
Comment on lines -1576 to -1593
<licenses>
<!-- Enforce this license:
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<license implementation="org.apache.rat.analysis.license.SimplePatternBasedLicense">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for this anymore since in a new version there is built-in matcher for Apache License

@flinkbot

flinkbot commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@snuyanzin

snuyanzin commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Confirmation that it is still behaving as expected in case of license header is missed from my fork https://github.com/snuyanzin/flink/actions/runs/29309720889/job/87010725070

@raminqaf raminqaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@snuyanzin snuyanzin merged commit d8ba8aa into apache:master Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants