[BP-2.0][FLINK-40086][runtime] Adds error handling to newly added preCompletionAction#28761
Open
cjohnson-confluent wants to merge 2 commits into
Open
[BP-2.0][FLINK-40086][runtime] Adds error handling to newly added preCompletionAction#28761cjohnson-confluent wants to merge 2 commits into
cjohnson-confluent wants to merge 2 commits into
Conversation
…listeners Execution.markFinished() and processFail() updated accumulators and IOMetrics after transitionState(), so ExecutionStateUpdateListeners notified inline during the transition saw null from getIOMetrics(). Add transitionToTerminalState() with a preCompletionAction callback that runs after the state is set but before terminalStateFuture is completed and listeners are notified. The metrics/accumulators update is passed as this callback so both terminalStateFuture consumers and listeners observe it. Applied to markFinished(), processFail(), completeCancelling() and recoverExecution(). Adapted for release-2.2: DefaultExecutionGraph#registerExecutionStateUpdateListener does not exist on this branch, so the test registers its listener at graph construction time via TestingDefaultExecutionGraphBuilder instead of going through a scheduler. Co-Authored-By: Claude <noreply@anthropic.com> (cherry picked from commit c0f774f) (cherry picked from commit 7244dc1)
…onAction (apache#28701) (cherry picked from commit c159e42)
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.0 backport for #28699
Depends on #28760 (FLINK-40003 backport). Please merge that first.