Iceberg full table corruption fix#4201
Draft
thisisArjit wants to merge 2 commits into
Draft
Conversation
…ata on publish Two related fixes for inter-cluster Iceberg full-table copy: 1. Determine which files to copy by diffing the source table against what the DESTINATION Iceberg catalog references, rather than probing each file's presence on the destination filesystem (config-gated, default on: iceberg.dataset.determine.copy.from.dest.catalog). Because the dest table is committed only after a fully successful publish, every path it references is guaranteed present and consistent, while orphan metadata left on the dest filesystem by a prior partially-failed run is NOT referenced -- so its missing data files are still re-copied. This prevents the table corruption that filesystem-presence short-circuiting can cause (a metadata file present on the dest FS skips its whole subtree forever, leaving the committed table referencing data files that never get copied). 2. On publish, rename data files before metadata files (HadoopUtils.renameRecursivelyOrdered) so Iceberg metadata is never committed ahead of the data it references. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Tests
Commits