[#12957] fix(lance): Prevent stale schema repair writes - #13014
Open
IcebreakerSA wants to merge 1 commit into
Open
[#12957] fix(lance): Prevent stale schema repair writes#13014IcebreakerSA wants to merge 1 commit into
IcebreakerSA wants to merge 1 commit into
Conversation
IcebreakerSA
force-pushed
the
codex/fix-lance-stale-schema-repair
branch
from
September 8, 2026 14:36
4dfe175 to
1936ad7
Compare
IcebreakerSA
force-pushed
the
codex/fix-lance-stale-schema-repair
branch
from
September 8, 2026 15:00
1936ad7 to
f0ac9aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Reload the complete Lance table repair observation after an optimistic lock conflict instead of retrying with previously read schema data. Before updating metadata, verify that the observed table ID, location, and Lance version still match the current table.
Add deterministic regression tests for concurrent metadata updates and table identity or location changes, plus integration coverage for persisting a newer Lance dataset schema through the catalog API.
Why are the changes needed?
A schema repair can read an older Lance dataset version and later overwrite metadata that already points to a newer version. A version check alone is also insufficient when a table is replaced or its location changes.
Fix: #12957
Does this PR introduce any user-facing change?
No API or property changes. Lance schema repair no longer writes schema metadata from a stale table observation.
How was this patch tested?
lance.versionremain persisted on a second read.