feat(collector): support milvus collector (#3877) - #4303
Open
paultanay wants to merge 14 commits into
Open
Conversation
paultanay
marked this pull request as ready for review
August 8, 2026 16:18
Duansg
requested changes
Aug 9, 2026
Duansg
marked this pull request as draft
August 9, 2026 15:42
paultanay
force-pushed
the
feature/milvus-collector
branch
from
August 11, 2026 18:14
f64a96f to
443ebdb
Compare
Aias00
previously approved these changes
Aug 17, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
Review: feat(collector): support milvus collector (#3877)
Verdict: ✅ APPROVED — useful new monitor template; please address two doc/metric notes before or after merge.
What this PR does
Adds a Milvus vector-DB monitor template (app-milvus.yml) scraping the Prometheus /metrics endpoint on port 9091, plus the matching help doc. Covers proxy request/slow-query/vector counts, search & mutation latency, QueryNode loaded collections/entities, and RootCoord collection/partition/DML/DDL counts across 12 priority groups.
Assessment
- Structure: Valid template — ASF license header, trilingual
name/help, sensibleparams(host/port/timeout), and consistentprotocol: http+parseType: prometheusper group. Port default 9091 and path/metricsmatch Milvus defaults. - Risk: Low — additive, no code path touched.
Notes (non-blocking)
- Doc/metric mismatch:
home/docs/help/milvus.mdlists metrics that the template does not define (e.g.milvus_proxy_sq_latency_sum,milvus_proxy_receive_bytes_count,milvus_proxy_send_bytes_count,milvus_querynode_search_req_latency_sum,milvus_querynode_search_group_nq_sum,milvus_querynode_evicted_memory_size). The "Collected Metrics" tables read like Milvus's full metric surface rather than what this template actually scrapes. Please align the doc tables with the 12 metric names present inapp-milvus.ymlso users aren't misled. - Histogram metric names:
milvus_proxy_sq_latencyandmilvus_proxy_mutation_latencyare modeled with anlelabel (classic histogram-bucket shape). Prometheus histograms expose..._bucket/..._sum/..._countseries; a baremilvus_proxy_sq_latencyseries usually does not exist, so these two groups may silently collect nothing. Please verify Milvus emits a bare series with thelelabel, or retarget the metric name tomilvus_proxy_sq_latency_bucket(and add_sum/_countas needed).
Nice addition overall.
paultanay
marked this pull request as ready for review
August 17, 2026 21:17
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Reworked the Milvus monitor to use HertzBeat's native
protocol: http+parseType: prometheus- no custom module, no new Java classes.hertzbeat-manager/src/main/resources/define/app-milvus.yml- monitoring template scraping Milvus's Prometheus endpoint (port 9091,/metrics), covering 12 metric groups: proxy request count, slow query count, search/insert vector counts, search and mutation latency histograms (histogram bucket series), QueryNode collection/entity counts, and RootCoord collection/partition/DML/DDL countshome/docs/help/milvus.md- English help documentation, metric tables aligned exactly to the templateFixes #3877