Feature: Incremental Append Scan#3364
Draft
smaheshwar-pltr wants to merge 1 commit into
Draft
Conversation
smaheshwar-pltr
force-pushed
the
sm/incremental-append-scan-v2
branch
from
f86284f to
1fd9274
Compare
smaheshwar-pltr
commented
May 17, 2026
| class BaseScan(ABC): | ||
| """A base class for all table scans.""" | ||
|
|
||
| class TableScan(ABC): |
Contributor
Author
There was a problem hiding this comment.
This isn't a rename - TableScan is just moved below the new BaseScan class
smaheshwar-pltr
commented
May 17, 2026
| and (manifest.sequence_number or INITIAL_SEQUENCE_NUMBER) >= min_sequence_number | ||
| ) | ||
| @property | ||
| def partition_filters(self) -> KeyDefaultDict[int, BooleanExpression]: |
Contributor
Author
There was a problem hiding this comment.
This is a public property, so keeping it for back-compat
smaheshwar-pltr
commented
May 17, 2026
|
|
||
|
|
||
| class DataScan(TableScan): | ||
| def _build_partition_projection(self, spec_id: int) -> BooleanExpression: |
Contributor
Author
There was a problem hiding this comment.
This is now moved into ManifestGroupPlanner so it can be shared with DataScan and IncrementalAppendScan.
smaheshwar-pltr
commented
May 17, 2026
| def plan_files( | ||
| self, | ||
| manifests: Iterable[ManifestFile], | ||
| manifest_entry_filter: Callable[[ManifestEntry], bool] = lambda _: True, |
Contributor
Author
There was a problem hiding this comment.
Introducing this for incremental append scan logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of #2634 (comment), please see those PRs for inline review comments + discussions that I've not ported to here just yet!
Rationale for this change
Are these changes tested?
Are there any user-facing changes?