Conversation
Commit-Check ✔️ |
Contributor
rishabhdaim
reviewed
Jun 26, 2026
rishabhdaim
left a comment
rishabhdaim
left a comment
Contributor
There was a problem hiding this comment.
Just a on comment on a test case.
Rest is fine with me.
Comment on lines
+54
to
+55
| assertEquals("foo", credentials.getUserID()); | ||
| assertEquals("bar", new String(credentials.getPassword())); |
Contributor
There was a problem hiding this comment.
exception would be thrown from above line.
These 2 are not reachable.
how about we add Assert.fail("shouldn't reach here") here.
Contributor
Author
There was a problem hiding this comment.
they may become reachable later on.
Contributor
Author
|
yes, this just adds test coverage for the existing behavior; bugs will be fixed separately. |
reschke
changed the title
rishabhdaim
approved these changes
Jun 26, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewers: not that this code is a demo project / POC only.