feat(computer-use): keep overlay cursor elevated when the aim point is covered - #5052
Open
wutongyuonce wants to merge 2 commits into
Open
feat(computer-use): keep overlay cursor elevated when the aim point is covered#5052wutongyuonce wants to merge 2 commits into
wutongyuonce wants to merge 2 commits into
Conversation
…s covered obscuringRects already travel from maka-cu through the observation record, and CuObservation says the agent cursor should test the point it is about to draw. keepElevated still sank whenever a window id existed. Pass the rects on overlay context and stay elevated only when that point hits one. Generated-by: pi-coding-agent
Hook-only cases cannot see computer-use-tools copy the observation record onto overlay context. Drive the real tool so a covered element centre stays elevated and an uncovered one still sinks. Generated-by: pi-coding-agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
obscuringRectsalready travel from maka-cu through the observation record, andCuObservationsays the agent cursor should test the point it is about to draw.keepElevatedstill sank whenever a window id existed, so a covered aim point could disappear under the covering window.This PR:
obscuringRectsto overlay contextDoes not change the desktop sink z-order implementation. Elevation is per point, not per whole window.
Fixes #5048
Does this PR entail a change in behavior?
Verification
npm --workspace @maka/runtime run buildnpm --workspace @maka/computer-use run buildnpm --workspace @maka/computer-use run test:dist— 122 pass, including hook-only point-in-rect cases anddriveRealToolwiring (covered centre stays up, uncovered centre still sinks)lint/format:check/ fulltypecheckAI use
Select exactly one:
Tool(s) and scope:
pi-coding-agent drafted the overlay context wiring, point-in-rect
keepElevated, tests, and this description. Commits carryGenerated-by: pi-coding-agent.Checklist