fix(desktop): reject duplicate in-flight CDP IDs - #5086
Open
liuxiaocs7 wants to merge 1 commit into
Open
Conversation
Prevent a second command on the same WebSocket from overwriting the pending entry for an active CDP command ID. Keep session routing intact and cover duplicate rejection, distinct IDs, and post-completion reuse. Fixes apache#5085 Generated-by: OpenAI Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject a duplicate CDP command ID while the original command is still in flight on the same WebSocket connection. This prevents the duplicate from overwriting the original pending entry, while preserving valid distinct IDs across sessions and allowing reuse after completion.
Fixes #5085
Verification
npm run lintnpm run format:checknpm run buildnpm run typechecknpx knip --workspace apps/desktopnpx knip --workspace packages/uinode --test apps/desktop/dist/main/__tests__/cdp-bridge.test.js(21 passed)AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex diagnosed the race, implemented the guard and regression test, ran verification, and prepared this pull request under the contributor's direction.
Checklist
Does this PR entail a change in behavior?