fix(desktop): compact WorkHub return button - #5087
Conversation
Generated-by: OpenAI Codex
jackwener
left a comment
There was a problem hiding this comment.
No findings.
At exact head ec1d4d3f4b9a268e8b8f07bd349e8b07f4de0fd5, the production control is already the shared small secondary Button; the page-specific .workhub-return rules were what replaced that appearance and stretched the control across the reading width. This patch removes those overrides and keeps only the three layout properties needed to make the button content-width and horizontally centered.
I rebuilt the Desktop app and ran the focused WorkHub reconstruction E2E suite: 2/2 tests passed. As a regression check, I restored the previous CSS rules while keeping the new test; the production button measured 800 px wide against a 606 px upper bound and the test failed at the intended assertion. Restoring this head made it pass again. The E2E budget check, Biome on both changed files, ASF header audit, and git diff --check also passed.
The hosted test check is completed successfully on this exact head. A synthetic merge with current main (30cf0beb0def57626df3fdbf8c7ab4d0d3436896) completed cleanly and preserves only this PR's two-file patch relative to main. I did not run the full workspace test suite or package builds beyond the Desktop E2E build.
Automated review notice: This comment was posted by an automated review agent operated by jackwener. It is not an independent human review and does not replace one.
The upstream WorkHub redesign removed the old return control and its owning reconstruction flow. Preserve the new upstream UI instead of restoring obsolete CSS and tests. The merged tree is identical to main. Generated-by: OpenAI Codex
|
Automated follow-up by OpenAI Codex on behalf of testikun (not an independent human review). Synchronized with current main in 4eb331e. Main has replaced the WorkHub presentation and removed the old .workhub-return control and its original reconstruction journey. Restoring that CSS/test would resurrect obsolete UI; the conflict resolution therefore preserves main, and the resulting tree is identical to main (f60fcb1). This PR is superseded by the upstream redesign and no longer has an effective code diff. No replacement button or unrelated behavior was introduced. |
Summary
The Return to WorkHub button above an ordinary Session's composer currently stretches to the reading width and overrides the shared Button styling. Keep it at content width, centered above the composer, and use the shared small secondary Button's appearance and vertical alignment.
Fixes #5063
Verification
npm run build:test, Desktop renderer build, and Desktop typecheck passed.git diff --checkpassed.AI use
Tool(s) and scope: OpenAI Codex authored the CSS change, regression assertions, and this PR description, and ran the recorded checks. The commit includes a
Generated-by: OpenAI Codextrailer. The human contributor remains responsible for review and submission.Checklist
Does this PR entail a change in behavior?