Skip to content

Upgrading to nb-javac from JDK 27b23#9413

Draft
lahodaj wants to merge 10 commits into
apache:masterfrom
lahodaj:jdk27
Draft

Upgrading to nb-javac from JDK 27b23#9413
lahodaj wants to merge 10 commits into
apache:masterfrom
lahodaj:jdk27

Conversation

@lahodaj
Copy link
Copy Markdown
Contributor

@lahodaj lahodaj commented May 29, 2026


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB31 milestone May 29, 2026
@lahodaj lahodaj added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels May 29, 2026
@mbien
Copy link
Copy Markdown
Member

mbien commented May 29, 2026

suggestion:

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 20f9322..b94eb02 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -1470,10 +1470,10 @@
     timeout-minutes: 60
     strategy:
       matrix:
-        java: [ '21', '26' ]
+        java: [ '21', '27-ea' ]
         config: [ 'batch1', 'batch2' ]
         exclude:
-          - java: ${{ github.event_name == 'pull_request' && 'nothing' || '26' }}
+          - java: ${{ github.event_name == 'pull_request' && 'nothing' || '27-ea' }}
       fail-fast: false
     steps:

the hints job was skipped in #9402 since it had to wait for the nb-javac update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants