HDDS-14774. Fix intermittent timeout in TestContainerReportHandling#10535
Merged
Conversation
amaliujia
approved these changes
Jun 19, 2026
Contributor
|
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
TestContainerReportHandling#testDeletingOrDeletedContainerWhenNonEmptyReplicaIsReportedintermittently times out on CI while waiting for replicas to be deleted.In this test, SCM only deletes a DELETING/DELETED container's replicas when it processes a container report. The test triggers that report once, by restarting the datanodes. Because
hdds.container.report.intervalis left at its 60-minute default, if that single report is disrupted (e.g. command expiry, missed heartbeat, or a datanode briefly marked stale/dead under CI load), the next report is 60 minutes away, far beyond the 180s wait, so the test times out.The fix sets
hdds.container.report.intervalto 1s, matching sibling tests (TestECContainerRecovery,TestBlockDeletion). A periodic report then re-triggers the deletion within seconds, so a single disrupted report can recover well within the wait.TestContainerReportHandlingWithHAshares the identical pattern and root cause, so it is fixed the same way in this PR.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14774
How was this patch tested?
TimeoutException; with the 1s interval added, they pass.TestContainerReportHandlingandTestContainerReportHandlingWithHAlocally; all parameters pass.checkstylepasses.Generated-by: Claude Code (Opus 4.8)