[python] Fix missing HTTP runtime dependencies#8044
Merged
JingsongLi merged 1 commit intoMay 31, 2026
Conversation
XiaoHongbo-Hope
force-pushed
the
fix/pypaimon-requests-runtime
branch
from
6a2ab9b to
353d82f
Compare
XiaoHongbo-Hope
changed the title
leaves12138
approved these changes
May 31, 2026
leaves12138
left a comment
leaves12138
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix. Adding the HTTP runtime dependencies to the Python requirements is small and targeted, and CI is green. Looks good to me.
Contributor
|
@XiaoHongbo-Hope Please merge #7960 first and rebase. |
XiaoHongbo-Hope
force-pushed
the
fix/pypaimon-requests-runtime
branch
from
353d82f to
26e3b9a
Compare
Contributor
|
+1 |
XiaoHongbo-Hope
added a commit
that referenced
this pull request
Jun 3, 2026
(cherry picked from commit 72027ef)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When users install PyPaimon in a clean environment with
pip install pypaimon, importingpypaimoncanfail because
requestsis missing:This was not obvious in 1.3.x because ossfs was still a runtime dependency, and it pulled in requests
and urllib3 transitively. In 1.4.x, ossfs was moved to optional dependencies, so clean installations no
longer get these HTTP dependencies for free.
The issue also tends to be hidden in many user/dev environments because requests and urllib3 are very
common packages and are often already installed by other tools or dependencies.
urllib3is also declared explicitly because PyPaimon directly importsurllib3.Retry, so we shouldnot rely on the transitive dependency from
requests.Tests