Skip to content

[arrow] Fix second-precision timestamp conversion for pre-epoch values #9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JingsongLi merged 1 commit into from
Sep 7, 2026
+21 −1
Merged

[arrow] Fix second-precision timestamp conversion for pre-epoch values #9600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paimon-arrow/src/main/java/org/apache/paimon/arrow/ArrowUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ public static void serializeToIpc(VectorSchemaRoot vsr, OutputStream out) {

private static long nonCastedTimestampToEpoch(Timestamp timestamp, int precision) {
if (precision == 0) {
return timestamp.getMillisecond() / 1000;
return Math.floorDiv(timestamp.getMillisecond(), 1000L);
} else if (precision >= 1 && precision <= 3) {
return timestamp.getMillisecond();
} else if (precision >= 4 && precision <= 6) {
Expand Down
20 changes: 20 additions & 0 deletions paimon-arrow/src/test/java/org/apache/paimon/arrow/vector/ArrowFormatWriterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,26 @@ public void testWrite() {
}
}

@Test
public void testWritePreEpochSecondPrecisionTimestamp() {
RowType rowType =
RowType.of(DataTypes.TIMESTAMP(0), DataTypes.TIMESTAMP_WITH_LOCAL_TIME_ZONE(0));
try (ArrowFormatWriter writer = new ArrowFormatWriter(rowType, 16, true)) {
// 1969-12-31T23:59:59.500, i.e. 500 millis before the epoch
Timestamp preEpoch = Timestamp.fromEpochMillis(-500);
writer.write(GenericRow.of(preEpoch, preEpoch));
writer.flush();

VectorSchemaRoot vectorSchemaRoot = writer.getVectorSchemaRoot();
ArrowBatchReader arrowBatchReader = new ArrowBatchReader(rowType, true);
InternalRow row = arrowBatchReader.readBatch(vectorSchemaRoot).iterator().next();

// sub-second millis must be truncated towards negative infinity, not towards zero
assertThat(row.getTimestamp(0, 0).toString()).isEqualTo("1969-12-31T23:59:59");
assertThat(row.getTimestamp(1, 0).toString()).isEqualTo("1969-12-31T23:59:59");
}
}

@Test
public void testMissingMapColumnVectorizedRoundTrip() {
RowType inputRowType = RowType.builder().field("id", DataTypes.INT()).build();
Expand Down
Loading